Qualifier tweaking #122813
Merged
Qualifier tweaking #122813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid Some changes occurred in need_type_info.rs cc @lcnr Some changes occurred in cc @BoxyUwU Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
nnethercote
force-pushed
the
nicer-quals
branch
from
f119374 to
55a92cf
Compare
|
☔ The latest upstream changes (presumably #122854) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
added
S-waiting-on-author
nnethercote
force-pushed
the
nicer-quals
branch
from
55a92cf to
02e7e3b
Compare
|
HIR ty lowering was modified cc @fmease |
In some cases `DUMMY_SP` is already imported. In other cases this commit adds the necessary import, in files where `DUMMY_SP` is used more than once.
Because that's the way it should be done.
Because they're a bit redundant.
So it doesn't clash with `rustc_middle::ty`.
nnethercote
force-pushed
the
nicer-quals
branch
from
02e7e3b to
b03ae74
Compare
|
I rebased and addressed the one nit. @bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#122813 (Qualifier tweaking) - rust-lang#122883 (refactor clippy in bootstrap) - rust-lang#123997 (Delay span bug when `Self` kw resolves to `DefKind::{Mod,Trait}`) - rust-lang#124045 (Reinstate nnethercote to the review rotation.) - rust-lang#124051 (Fix empty-set symbol in comments) - rust-lang#124052 (Make the comments for `ReturnDest` variants doc comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
Rollup merge of rust-lang#122813 - nnethercote:nicer-quals, r=compiler-errors Qualifier tweaking Adding and removing qualifiers in some cases that make things nicer. Details in individual commits. r? `@compiler-errors`
|
Still shows up in the queue somehow... |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-author
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
…r-errors Qualifier tweaking Adding and removing qualifiers in some cases that make things nicer. Details in individual commits. r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding and removing qualifiers in some cases that make things nicer. Details in individual commits.
r? @compiler-errors